-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👎 on Rails/HelperInstanceVariable #28
Comments
This one is enabled by default in rubocop-rails, and I think it generally makes sense to leave enabled and require per-usage disable if desired. In the issue example (what I'm assuming is setting an html title element on a page in a generic way that will work across the whole app?), I'd probably look for a way to either:
|
Interesting. Reading the cop docs, the intent seems to be,
But @searls your design accounts for this. BTW, I like your design of having the logic for all the HTML titles in one place. Because, these are usu. part of a comprehensive HTML metadata strategy. So it'd be nice to see them all in one place. |
Yeah I think I'd be cool with a PR disabling this |
I ended up turning this off b/c it was a show-stopper to getting my new app standard-rails compliant :yolo: 2733934 |
I'm using standard-rails in earnest for the first time so I suspect there will be a few issues like this soon.
This fails with
Do not use instance variables in helpers.standard(Rails/HelperInstanceVariable)
, even though there's a check right there that the ivar is availableThe text was updated successfully, but these errors were encountered: