Trailing comma rule results in },]) contortion

[searls]

Standard keeps slamming the final , into this and I hate it:

    Item.find_by_sql([sql, {
      user_id: user.id,
      answer: answer,
    },]).uniq

There's no way anyone thinks },]) is preferable in this case, right?

[pcriv]

Yup, I don't like it either 😬
Would the solution be only adding the comma to the last element of a hash?

[searls]

Yes, one would think

[GeoffAbtion]

},]) is undesirable but I think it is a symptom of another problem, you're trying to wrap a hash in a strange way. Of course that is going to look wrong.

These all look reasonable:

Item.find_by_sql(
  [
    sql,
    {
      user_id: user.id,
      answer: answer,
    },
  ]
).uniq

Item.find_by_sql([
  sql,
  {
    user_id: user.id,
    answer: answer,
  },
]).uniq

Item.find_by_sql([
  sql,
  {user_id: user.id, answer: answer},
]).uniq

Item.find_by_sql([sql, {user_id: user.id, answer: answer}]).uniq

2. is probably what I'd want to see.

[jmkoni]

Pretty sure we fixed this in a7156b1