Fix end position of diagnostic for LSP #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rubocop/rubocop#12932. This is a porting because it can be said that even Standard.rb, which serves as the base for RuboCop's built-in LSP, does the same thing. --- This is a quote from rubocop/rubocop#12932. `character` of `Position` is zero-based https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#position > Character offset on a line in a document (zero-based). And, `Parser::Source::Range` is also zero-based https://github.com/whitequark/parser/blob/3e260d2e37bcb3de8705489d1c2799c26c7a2215/lib/parser/source/range.rb#L104 > zero-based column number of the end of this range. Therefore, `-1` is not necessary.
|
Thanks for back/forward/down porting this for us -- I would've missed it otherwise. Incidentally, I was looking at the exact same line of code in my spike of a Ruby LSP addon today, so I'll fix this there too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop#12932.
This is a porting because it can be said that even Standard.rb, which serves as the base for RuboCop's built-in LSP, does the same thing.
This is a quote from rubocop/rubocop#12932.
characterofPositionis zero-basedhttps://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#position
And,
Parser::Source::Rangeis also zero-basedhttps://github.com/whitequark/parser/blob/3e260d2e37bcb3de8705489d1c2799c26c7a2215/lib/parser/source/range.rb#L104
Therefore,
-1is not necessary.