Allow using local GTest #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoni206
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Looks good and will speed things up.
Two questions:
- Perhaps it should verify that the local GTest is of the correct version, and only then avoid from downloading it?
- What do you think about having an option for this PR? The default could be the new behavior, but it would be nice when running
configure.shto force a new download of gtest.
Both questions arise from painful previous experience with Gtest versions. And if that happens, or anything else goes wrong, it would be nice to just change an option in order to make sure that the right version is downloaded.
|
@yoni206 as per your request, added version check and flag to force downloading. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This searches for the system-provided version of GTest first, and only downloads it if it's not available.
Another possible improvement would be to not re-download GTest every time
configure.shis run.