Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch script multislice #629

Open
blahBlahhhJ opened this issue Jun 12, 2024 · 6 comments
Open

Launch script multislice #629

blahBlahhhJ opened this issue Jun 12, 2024 · 6 comments

Comments

@blahBlahhhJ
Copy link
Contributor

Things I'm going to add to launch.py

  1. Migrate some commands API from tpu-vm to queued-resources to work better with multislice training
  2. Delete the instance if command fail (regardless of autodelete) so that it won't eat up all the quota after many retries
@blahBlahhhJ
Copy link
Contributor Author

@dlwh @rjpower FYI

@rjpower
Copy link
Collaborator

rjpower commented Jun 12, 2024

For (1) SGTM, let me know if I can help. Something simple that just runs queued-resources create and then polls until the instance is started seems like a good first step.
For (2) don't we normally want to reuse the instance? That's much faster for me in practice than delete/restart. (Or is this for batch job, in which case, sure, makes sense as an option).

@blahBlahhhJ
Copy link
Contributor Author

In my experience when an instance is preempted (suspended), then you cannot create another one with the same name. The suspended instance is going to stay there and take up the quota.

@dlwh
Copy link
Member

dlwh commented Jun 12, 2024 via email

@blahBlahhhJ
Copy link
Contributor Author

@rjpower is there a way to specify which branch to run?

@rjpower
Copy link
Collaborator

rjpower commented Jun 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants