Subclass from colbert.data.Collection fails cast assertion

[bagchisu]

The cast() classmethod in colbert.data.Collection has uses the following to test the type of the obj argument:

        if type(obj) is cls:
            return obj

This fails when the collection object passed to colbert.Searcher is a subclass of Collection. Perhaps a better implementation for the type check in cast would be:

        if isinstance(obj, cls):
            return obj

[okhat]

Agreed. If you make a pull request I'll merge it!

[bagchisu]

I don't have permission to push a new branch with this change. How should I do a PR? ERROR: Permission to stanford-futuredata/ColBERT.git denied to bagchisu. Regards, Sugato

…

On Mon, Dec 12, 2022 at 3:37 PM Omar Khattab ***@***.***> wrote: Agreed. If you make a pull request I'll merge it! — Reply to this email directly, view it on GitHub <#147 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD2O45S2C7XEV2VAJSDICMTWM6EHFANCNFSM6AAAAAASU2ZVFI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[okhat]

You can create a new PR from here: https://github.com/stanford-futuredata/ColBERT/pulls