Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes that ended up in wip/nrser/skill-perf #1117

Merged
merged 8 commits into from
Oct 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion k8s/config/dev/manager-config/developer-deployment.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"run-worker",
"--thingpedia-url=http://frontend:8080/thingpedia",
"--nl-server-url=https://nlp-staging.almond.stanford.edu",
"--oauth-redirect-origin=http://frontend:8080",
"--oauth-redirect-origin=http://localhost:8080",
"--faq-models={}",
"--notification-config={}",
"--locale=en-US",
Expand Down
4 changes: 3 additions & 1 deletion k8s/frontend/base/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ metadata:
nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
# set a very large value so we can upload string datasets
nginx.ingress.kubernetes.io/proxy-body-size: "64m"
nginx.ingress.kubernetes.io/proxy-max-temp-file-size: "1024m"
nginx.org/client-max-body-size: "64m"
labels:
app: frontend
spec:
Expand All @@ -17,7 +19,7 @@ spec:
port:
number: 8080
rules:
- host: almond-cloud.test
- host: localhost
http:
paths:
- backend:
Expand Down
4 changes: 2 additions & 2 deletions model/schema.sql
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ CREATE TABLE `user_conversation` (
`intermediateContext` text COLLATE utf8mb4_bin NULL,
`user` varchar(255) COLLATE utf8mb4_bin NOT NULL,
-- iso 8601 string (for sqlite compatibility)
`userTimestamp` char(24) COLLATE utf8mb4_bin NOT NULL,
`userTimestamp` char(24) COLLATE utf8mb4_bin NULL,
`userTarget` text COLLATE utf8mb4_bin NOT NULL,
`vote` ENUM('up', 'down') COLLATE utf8mb4_bin NULL,
`comment` text COLLATE utf8mb4_bin NULL,
Expand Down Expand Up @@ -1092,4 +1092,4 @@ CREATE TABLE `user_conversation_state` (
`lastMessageId` int(11) NULL,
PRIMARY KEY (`userId`, `uniqueId`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;
/*!40101 SET character_set_client = @saved_cs_client */;
/*!40101 SET character_set_client = @saved_cs_client */;
2 changes: 1 addition & 1 deletion src/nlp/nlp_model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export default class NLPModel {
[
"options",
NLPModel.orderedPairsFor(
options, ["tokenized", "expect", "choices", "store"]
options, ["context", "entities", "tokenized", "expect", "choices", "store"]
)
],
]);
Expand Down