Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/update docs #79

Merged
merged 8 commits into from
Oct 23, 2018
Merged

Wip/update docs #79

merged 8 commits into from
Oct 23, 2018

Conversation

sileix
Copy link
Member

@sileix sileix commented Oct 22, 2018

tutorials for writing manifest.tt and dataset.tt

@sileix sileix requested a review from gcampax October 22, 2018 20:31
@coveralls
Copy link

coveralls commented Oct 22, 2018

Pull Request Test Coverage Report for Build 135

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.483%

Totals Coverage Status
Change from base Build 129: 0.0%
Covered Lines: 4124
Relevant Lines: 7139

💛 - Coveralls

@gcampax
Copy link
Contributor

gcampax commented Oct 23, 2018

One thing I noticed that you tend to do, and it would be good to address, is that you tend to omit articles, even when the sentence is not grammatical anymore.
Eg rather "Writing manifest" you should write "Writing a manifest" or "Writing the manifest" (probably the latter)

Alternatively, you need to pluralize the noun, eg "Writing Device Classes" is fine, "Writing Device Class" is not.

@sileix
Copy link
Member Author

sileix commented Oct 23, 2018

One thing I noticed that you tend to do, and it would be good to address, is that you tend to omit articles, even when the sentence is not grammatical anymore.
Eg rather "Writing manifest" you should write "Writing a manifest" or "Writing the manifest" (probably the latter)

Alternatively, you need to pluralize the noun, eg "Writing Device Classes" is fine, "Writing Device Class" is not.

Thanks. That has been a bad habit for me for a long time...

doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
doc/thingpedia-device-class.md Outdated Show resolved Hide resolved
@sileix sileix merged commit b4b2913 into master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants