Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Train Almond: catch syntax errors inside the promise #88

Merged
merged 1 commit into from Oct 25, 2018
Merged

Train Almond: catch syntax errors inside the promise #88

merged 1 commit into from Oct 25, 2018

Conversation

gcampax
Copy link
Contributor

@gcampax gcampax commented Oct 25, 2018

So we can report them to the user

Fixes #23

@gcampax gcampax added the bug label Oct 25, 2018
@gcampax gcampax requested a review from sileix October 25, 2018 05:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 159

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.363%
Totals Coverage Status
Change from base Build 157: 0.0%
Covered Lines: 4172
Relevant Lines: 7110
💛 - Coveralls

@gcampax
Train Almond: catch syntax errors inside the promise
512a903 
So we can report them to the user

Fixes #23
@gcampax gcampax merged commit 77dd2f3 into master Oct 25, 2018
@gcampax gcampax deleted the wip/issue-23 branch October 25, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sileix sileix sileix approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gcampax @coveralls @sileix