Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify skill grid #200

Merged
merged 10 commits into from
May 21, 2021
Merged

Beautify skill grid #200

merged 10 commits into from
May 21, 2021

Conversation

spacegaier
Copy link
Contributor

@spacegaier spacegaier commented May 11, 2021

A few visual tweaks:

  1. Ensure that all skill boxes in a row have the same height (flex box approach that also works with smaller screen sizes).
  2. Use correct hover icon for footer (pointer instead of grab).

After:
image

@gcampax
Copy link
Contributor

gcampax commented May 11, 2021

@almakantara is also working on a visual update of the My Skills page in #189. Perhaps you can coordinate this effort?

@spacegaier
Copy link
Contributor Author

@almakantara is also working on a visual update of the My Skills page in #189. Perhaps you can coordinate this effort?

Did not see that, since the PR title only mentions the chat interface...

@spacegaier
Copy link
Contributor Author

spacegaier commented May 20, 2021

@almakantara Now that #189 has been merged I updated my PR accordingly.

@almakantara
Copy link
Contributor

@almakantara Now that #189 has been merged I update my PR accordingly.

ok, thanks

Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue

views/devices_list.pug Outdated Show resolved Hide resolved
Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good now.

@gcampax gcampax merged commit 0c28505 into stanford-oval:master May 21, 2021
@spacegaier spacegaier deleted the skill-grid branch May 21, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants