-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filters.genie for Chinese #11
Conversation
@gcampax |
You can add the helpers and new code to ast_manip yeah. |
for example, if I want my blood pressure records between 2019/01/01~2019/02/25, then I need that. |
A get predicate is a filter on the current date when the code is evaluated, not on the date of the record. What you want is a range filter of type Date. |
f23d0a7
to
33c7298
Compare
I see. Thank you! |
languages/zh-tw/filters.genie
Outdated
}; | ||
v1:constant_Date ('和' | '跟') v2:constant_Date '之間'=> { | ||
if (!v1.getType().equals(v2.getType())) | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will never trigger, because range_filter only pairs the range to a numeric (number, currency, measure) parameter, not a date parameter.
Also, the v1.getType().equals( v2.getType())
check is redundant because you're asking for Date constants through the grammar non-terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at it and I didn't see anything obviously wrong, but I'm adding @rayslxu to take a look at it too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add some comments based on Chinese in Mainland China. (things might be slightly different in Taiwan, I don't know)
Thank you! I modified some according to your review. |
In particular bump consumer-queue to 1.0.1, which fixes a pretty bad bug Fixes #11
translate filters.genie for Chinese