Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin mmap-io to 1.0.0 #32

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Conversation

gcampax
Copy link
Contributor

@gcampax gcampax commented Apr 11, 2019

mmap-io 1.1.0 is busted, see ozra/mmap-io#17

@gcampax gcampax merged commit eca2b3e into master Apr 11, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/mmap-io-pin-1.0.0 branch April 11, 2019 03:15
@ozra
Copy link

ozra commented Jul 9, 2019

Sorry I didn't see the notifications earlier. Bumped to 1.1.3 today with the C++ portion caught up with the breaking changes in Nan/V8/Node 12.x, if you want to try it out. Builds passed on Linux and Mac, node 10.16.0 (LTS) and node 12.6.0 (latest).

@gcampax
Copy link
Contributor Author

gcampax commented Jul 9, 2019

Hey, thanks for weighing in on this. I'm afraid 1.1.3 is still problematic, because the JS code still refers to the build .node file in the wrong location: https://travis-ci.com/stanford-oval/genie-toolkit/builds/118500925

@ozra
Copy link

ozra commented Jul 10, 2019

Try your luck with 1.1.6 — I added it to a fresh proj and it worked — after several very silly mistakes.
It doesn't refer to the wrong place — it points to a js-wrapper-module that includes the .node module in turn. It just so happened that the js-files vanished before reaching end-user installment xD Really stupid mistake. It's all in the changelog for the curious.

gcampax added a commit that referenced this pull request Jun 23, 2020
…ingtalk

Update to work with the latest thingtalk and thingpedia-client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants