Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enum value translation for Chinese #35

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Add enum value translation for Chinese #35

merged 5 commits into from
Apr 18, 2019

Conversation

johnnychhsu
Copy link
Contributor

Modify postprocessSynthetic() in tranditional-chinese.js. Adding translation code

@johnnychhsu johnnychhsu force-pushed the chinese/sentence_post_process branch from 99f1200 to 86300c1 Compare April 17, 2019 08:29
@johnnychhsu
Copy link
Contributor Author

add tests for traditional-chinese.js postprocessSynthetic().

gcampax
gcampax approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a great place to put that info, but I guess it will do for now.

@johnnychhsu johnnychhsu merged commit ff1513b into master Apr 18, 2019
@gcampax gcampax deleted the chinese/sentence_post_process branch May 2, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcampax gcampax gcampax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnnychhsu @gcampax