Miscellaneous fixes #823
Merged
Miscellaneous fixes #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the row If the user asks for "when there are new X", make that a monitor on the ID (if X is a list and has an `id` argument), so unrelated changes to the current rows of X won't cause a notification. Conversely, when the user asks for "when the X change", we monitor and notify on everything.
gcampax
added
bug
And pluralize the ones that don't have the flag already (assuming they start off singular, which they should)
To support proper translation, we need to merge all canonical forms into a single translated string, and then let translator replace all the forms as a unit. That way they can eliminate those that are not useful/translatable, introduce new ones that are necessary, distinguish variants by more than pos (eg gender, number), and specify a different set of pos than English.
sileix
approved these changes
Oct 25, 2021
gcampax
force-pushed
the
wip/misc-fixes
branch
from
8bf14fa
to
ea91d8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.