Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requote #824

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Update requote #824

merged 1 commit into from
Oct 27, 2021

Conversation

Mehrad0711
Copy link
Member

Add option to write failed examples to the same output file. Also output the actual error, not just the example id

This was referenced Oct 25, 2021
Merged
Merged
@gcampax
Copy link
Contributor

gcampax commented Oct 25, 2021

This code is not quite understandable. What are you trying to do?

@Mehrad0711
Copy link
Member Author

Currently if you pass the same file for --output and --output-errors it wouldn't work. The requoted examples will be written to output but erred examples are lost. I changed it so if the output paths are the same we won't be creating a new writeStream and write all examples to output.

gcampax
gcampax reviewed Oct 26, 2021
View reviewed changes
tool/requote.js Outdated Show resolved Hide resolved
@Mehrad0711 Mehrad0711 force-pushed the wip/update-requote branch 2 times, most recently from fed2468 to fd0854c Compare October 27, 2021 03:12
gcampax
gcampax approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@gcampax gcampax merged commit b68f2e2 into master Oct 27, 2021
@gcampax gcampax deleted the wip/update-requote branch October 27, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcampax gcampax gcampax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mehrad0711 @gcampax