Fix dialogue ID of parsed dialogues if the previous dialogue is empty #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a unit test for dialogue parsing, because it's high time we have one instead of relying on downstream usage to catch bugs.
gcampax
force-pushed
the
wip/fix-dataset-parser
branch
3 times, most recently
from
69efd51
to
a31148a
Compare
gcampax
force-pushed
the
wip/fix-dataset-parser
branch
from
a31148a
to
910ec76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a unit test for dialogue parsing, because it's high time
we have one instead of relying on downstream usage to catch bugs.