add support for measurement type #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sileix
reviewed
Mar 28, 2022
jmhw0123
force-pushed
the
wip/synthetic-data-sampler
branch
from
9242bd8
to
195e8ac
Compare
support measurement type
sileix
force-pushed
the
wip/synthetic-data-sampler
branch
from
195e8ac
to
55b71b8
Compare
sileix
requested changes
Apr 7, 2022
There was a problem hiding this comment.
As it gets more and more complicated, I think we should have a unit test for it. Use a small fake schema with different thingtalk types to test it. Probably a good idea to have a parameter to control how many examples per annotation - so we can set it to 1 to make the unit test shorter.
| if (argument.type instanceof Type.Measure) | ||
| argumentCanonical = '#' + argumentCanonical; | ||
| else | ||
| argumentCanonical = argumentCanonical + ' #'; |
tool/sample-synthetic-data.ts
Outdated
| function retrieveSampleValues(classDef : Ast.ClassDef, | ||
| sampleMeta : Record<string, Constant[]>, | ||
| fname : string, | ||
| arg : Ast.ArgumentDef) : string[] { | ||
| if (arg.type instanceof Type.Enum) | ||
| return arg.type.entries!.slice(0, 10).map(utils.clean); | ||
| if (arg.type instanceof Type.Measure) | ||
| return generateRandomIntArray(100).map(String); |
There was a problem hiding this comment.
include number, time, date, and location?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the measurement type