Expand primitives based on heuristics #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to expand templates at the device level easily
Only use primitives with filter in it and canonical in utterance to expand
- do not expand if the canonical appears multiple times - correctly handle canonical matching, i.e., handle cases where canonical contains multiple tokens
- in case that only "everything" dataset is available, load the dataset without expansion
gcampax
reviewed
Sep 28, 2019
gcampax
pushed a commit
that referenced
this pull request
Jun 23, 2020
Add link to register matrix account when there is no messaging account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To further reduce the amount of work needed from developers, a heuristic expander is added to generate more primitives based on the provided dataset.
The basic idea is that for each primitive example
e:(1) if
eis a filter, and its utterance contains the canonical of the function, use it as anexpander(2) for other primitive examples using the same function, use their utterances to replace the canonical in
e's utterance, and at the same time apply the filter ine.We currently only apply this to filters, we can probably also apply it to other grammar too.