Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import utilities to create device factories from almond-cloud #42

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

gcampax
Copy link
Contributor

@gcampax gcampax commented Oct 18, 2019

This is code that has been copied to almond-cmdline and almond-server
to implement "developer mode", and it's best if shared. Also,
this simplifies adding new kinds of loaders or config modules,
cause almond-cloud no longer needs to change.

This is code that has been copied to almond-cmdline and almond-server
to implement "developer mode", and it's best if shared. Also,
this simplifies adding new kinds of loaders or config modules,
cause almond-cloud no longer needs to change.
@gcampax
Copy link
Contributor Author

gcampax commented Oct 18, 2019

Btw, I don't quite like the name DeviceFactoryUtils, because it overlaps with DeviceFactory (which is a different thing). I'm open to suggestions of a better name before this becomes API we have to maintain until Tp 3.0

@coveralls
Copy link

coveralls commented Oct 18, 2019

Pull Request Test Coverage Report for Build 217

  • 45 of 55 (81.82%) changed or added relevant lines in 2 files are covered.
  • 43 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.2%) to 83.81%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/device_factory_utils.js 43 53 81.13%
Files with Coverage Reduction New Missed Lines %
lib/base_client.js 1 85.71%
lib/base_device.js 1 95.65%
lib/helpers/polling.js 1 95.0%
lib/base_engine.js 2 80.0%
lib/helpers/ref_counted.js 2 86.27%
lib/utils.js 2 91.09%
lib/helpers/file_prefs.js 5 77.78%
lib/factory.js 6 62.5%
lib/helpers/object_set.js 6 84.62%
lib/http_client.js 8 78.26%
Totals Coverage Status
Change from base Build 207: -0.2%
Covered Lines: 1203
Relevant Lines: 1380

💛 - Coveralls

Get the kind from the class
So code coverage doesn't go down too much
Copy link
Member

@sileix sileix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call it DeviceCofigUtils?

@gcampax gcampax merged commit e64627e into master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants