Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AXI4 Compatibilty Issue #299

Open
kelayamatoz opened this issue Mar 2, 2020 · 0 comments
Open

AXI4 Compatibilty Issue #299

kelayamatoz opened this issue Mar 2, 2020 · 0 comments
Assignees

Comments

@kelayamatoz
Copy link
Collaborator

Right now, it seems that our WVALID assertion depends on AWREADY. This is caused by how we implement wdata.valid signal coming out of AXICmdIssue:

io.out.wdata.valid := io.in.wdata.valid & writeIssued
. Since qsys' interconnect scheduler only assigns AWREADY to network ready when AWVALID and WVALID are both high, our implementation would lead to a deadlock when SpatialIP is connected with an Intel qsys interconnect.

For now, I fixed this on the sflow branch by directly connecting the in.wdata.valid and out.wdata.valid. It seems to fix the issues for a subset of tests apps on the DE1 board. I'm not sure if it would cause problems for the Xilinx boards. We may want to try this fix with the regressions on Xilinx boards and see what happens. @mattfel1 What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants