Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simple Tests #35

Merged
merged 19 commits into from
Dec 28, 2019
Merged

Add Simple Tests #35

merged 19 commits into from
Dec 28, 2019

Conversation

wakame1367
Copy link
Contributor

I made a simple test with reference to the test in this Link.

@tonyduan
Copy link
Collaborator

Hi! Thank you for the contribution. Wanted to give you a heads up I've pushed some minor changes to the master branch. The most significant API change is that the Score is now static, i.e. instead of
ngb = NGBoost(Base=default_tree_learner, Dist=Normal, Score=MLE(),
an instantiation would look like
ngb = NGBoost(Base=default_tree_learner, Dist=Normal, Score=MLE,.

Sorry for the inconvenience and thanks again!

@wakame1367
Copy link
Contributor Author

Hi! Thank you for the contribution. Wanted to give you a heads up I've pushed some minor changes to the master branch. The most significant API change is that the Score is now static, i.e. instead of
ngb = NGBoost(Base=default_tree_learner, Dist=Normal, Score=MLE(),
an instantiation would look like
ngb = NGBoost(Base=default_tree_learner, Dist=Normal, Score=MLE,.

Sorry for the inconvenience and thanks again!

OK, I reflected it👌

@alejandroschuler alejandroschuler merged commit 4c40ab6 into stanfordmlgroup:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants