Update lists, LST, to be num (SD) or nummod (UD) of the governor. Add…

…resses another portion of #1363
stanfordnlp · Jul 8, 2023 · 5745de5 · 5745de5
1 parent 9a86ece
commit 5745de5
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 8 deletions.
diff --git a/src/edu/stanford/nlp/trees/EnglishGrammaticalRelations.java b/src/edu/stanford/nlp/trees/EnglishGrammaticalRelations.java
@@ -935,15 +935,24 @@ private EnglishGrammaticalRelations() {}
   /**
    * The "numeric modifier" grammatical relation.  A numeric
    * modifier of an NP is any number phrase that serves to modify
-   * the meaning of the NP.<p>
+   * the meaning of the NP.
+   * <br>
+   * Also, the enumeration of lists have this relation to the head of
+   * the list item.  For that, we allow the list of constituents which
+   * have a list under them in any of the training data, as the parser
+   * will likely not produce anything else anyway.
    * <br>
+   * PTB: PP NP X S FRAG <br>
+   * EWT: SQ SBARQ SINV SBAR NML VP <br>
+   * Craft: PRN <br>
+   * OntoNotes: ADJP <br>
    * Example: <br>
    * "Sam eats 3 sheep" &rarr;
    * {@code num}(sheep, 3)
    */
   public static final GrammaticalRelation NUMERIC_MODIFIER =
     new GrammaticalRelation(Language.English, "num", "numeric modifier",
-        MODIFIER, "(?:WH)?NP(?:-TMP|-ADV)?|NML|NX|ADJP|WHADJP|QP", tregexCompiler,
+        MODIFIER, "(?:WH)?NP(?:-TMP|-ADV)?|NML|NX|ADJP|WHADJP|QP|PP|X|S|FRAG|SQ|SBARQ|SINV|SBAR|VP|PRN", tregexCompiler,
             "/^(?:WH)?(?:NP|NX|NML)(?:-TMP|-ADV)?$/ < (CD|QP=target !$- CC)",
             // $ is so phrases such as "$ 100 million buyout" get amod(buyout, $)
             "/^(?:WH)?(?:NP|NX|NML)(?:-TMP|-ADV)?$/ < (ADJP=target <: (QP !< /^[$]$/))",
@@ -952,7 +961,9 @@ private EnglishGrammaticalRelations() {}
             // Note that the earlier tregexes are usually enough to cover those phrases, such as when
             // the QP is by itself in an ADJP or NP, but sometimes it can have other siblings such
             // as in the phrase "$ 100 million or more".  In that case, this next expression is needed.
-            "QP < QP=target < /^[$]$/");
+            "QP < QP=target < /^[$]$/",
+            // Lists are treated as nummod in UD_English-EWT
+            "PP|NP|X|S|FRAG|SQ|SBARQ|SINV|SBAR|NML|VP|PRN|ADJP < LST=target");
 
 
   /**

diff --git a/src/edu/stanford/nlp/trees/UniversalEnglishGrammaticalRelations.java b/src/edu/stanford/nlp/trees/UniversalEnglishGrammaticalRelations.java
@@ -860,15 +860,25 @@ private UniversalEnglishGrammaticalRelations() {}
   /**
    * The "numeric modifier" grammatical relation.  A numeric
    * modifier of an NP is any number phrase that serves to modify
-   * the meaning of the NP.
-   * <br>
+   * the meaning of the NP.  Also, the enumeration of lists have
+   * this relation to the head of the list item.
+   * <br>
+   * Also, the enumeration of lists have this relation to the head of
+   * the list item.  For that, we allow the list of constituents which
+   * have a list under them in any of the training data, as the parser
+   * will likely not produce anything else anyway.
+   * <br>
+   * PTB: PP NP X S FRAG <br>
+   * EWT: SQ SBARQ SINV SBAR NML VP <br>
+   * Craft: PRN <br>
+   * OntoNotes: ADJP <br>
    * Example: <br>
    * "Sam eats 3 sheep" &rarr;
    * {@code nummod}(sheep, 3)
    */
   public static final GrammaticalRelation NUMERIC_MODIFIER =
     new GrammaticalRelation(Language.UniversalEnglish, "nummod", "numeric modifier",
-        MODIFIER, "(?:WH)?NP(?:-TMP|-ADV)?|NML|NX|ADJP|WHADJP|QP", tregexCompiler,
+        MODIFIER, "(?:WH)?NP(?:-TMP|-ADV)?|NML|NX|ADJP|WHADJP|QP|PP|X|S|FRAG|SQ|SBARQ|SINV|SBAR|VP|PRN", tregexCompiler,
             "/^(?:WH)?(?:NP|NX|NML)(?:-TMP|-ADV)?$/ < (CD|QP=target !$- CC)",
             // $ is so phrases such as "$ 100 million buyout" get amod(buyout, $)
             "/^(?:WH)?(?:NP|NX|NML)(?:-TMP|-ADV)?$/ < (ADJP=target <: (QP !< /^[$]$/))",
@@ -877,8 +887,9 @@ private UniversalEnglishGrammaticalRelations() {}
             // Note that the earlier tregexes are usually enough to cover those phrases, such as when
             // the QP is by itself in an ADJP or NP, but sometimes it can have other siblings such
             // as in the phrase "$ 100 million or more".  In that case, this next expression is needed.
-            "QP < QP=target < /^[$]$/");
-
+            "QP < QP=target < /^[$]$/",
+            // Lists are treated as nummod in UD_English-EWT
+            "PP|NP|X|S|FRAG|SQ|SBARQ|SINV|SBAR|NML|VP|PRN|ADJP < LST=target");
 
 
   /**