Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Keeping Nested/Overlapping Matches from CoreMapExpressionExtractor and Expose the Name #1307

Open
jrsperry opened this issue Oct 10, 2022 · 3 comments

Comments

@jrsperry
Copy link

jrsperry commented Oct 10, 2022

In my work we have used tokens-regex, but I'm looking to use the lower-level CoreMapExpressionExtractor and to modify it to allow for matches that are either nested, or overlapping.

For my use case I want to see all possible matches, not just the largest or non-overlapping matches. I'm only using the result functionality of the language, not doing any annotating.

I would also like to expose the name of the ExtractFunc of the MatchedExpression.

I have changes checked in to a local branch where I expose the name, and allow for the Env of the CoreMapExpressionMatcher to allow for all the matches to be returned or not.

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Oct 10, 2022 via email

@jrsperry
Copy link
Author

i've already done that, I figured it may be of use to others using the CoreMapExpressionExtractor. I'll attach a PR for consideration.

@jrsperry
Copy link
Author

jrsperry commented Oct 10, 2022

Not sure how to assign it to this issue but here's the PR.
#1308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants