Collinizer #1344
Merged
Collinizer #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngledLuffa
force-pushed
the
collinizer
branch
from
262493f
to
e433ca8
Compare
…te the transform method so the gold & guess trees can have the same punctuation treatment
AngledLuffa
force-pushed
the
collinizer
branch
from
e433ca8
to
5b9e65d
Compare
- the plan is to make the AbstractCollinizer use a difference interface
… tree and the gold tree Not used yet, though - the gold tree is ignored for now
…ld tree can be used to determine whether or not to eliminate the words in the guess tree. This will make it so the test & gold trees are the same, hopefully eliminating most or all of the 'Unable to evaluate...' that happens after retagging trees with the POS tagger Also do the ChineseCollinizer and the NegraPennCollinizer. Both are tested using derivatives of the English test (using English trees, but with the tags specific for the other treebank)
AngledLuffa
force-pushed
the
collinizer
branch
from
5b9e65d
to
f6f2d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the collinizer to delete words based on the gold tags, not the guess tags, in case the POS tagger disagrees with the original treebank on which words are symbols vs punct