Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 (& 3.12) #1293

Open
michael-k opened this issue Oct 5, 2023 · 4 comments
Open

Add support for Python 3.11 (& 3.12) #1293

michael-k opened this issue Oct 5, 2023 · 4 comments

Comments

@michael-k
Copy link

Is your feature request related to a problem? Please describe.

We're already running stanza on Python 3.11 and are planning to move to 3.12 as soon as torch supports it. Would be nice if both versions could be officially supported.

Describe the solution you'd like

Ensure that stanza works on Python 3.11 & 3.12 and add a trove classifier.

Describe alternatives you've considered

None

Additional context

  • Works for our use case on Python 3.11 without issues.
  • For Python 3.12 you probably want to wait until torch has published wheels. (This might take a while.)
  • You could also drop support for Python 3.6 & 3.7 if you like. Both reached their end-of-life a while ago.
@AngledLuffa
Copy link
Collaborator

Good call. I just found a bug in the way the latest version handles Arabic POS tags, so I will release a patch for that tonight and add support for 3.11. We can announce that 3.6 support will go away with the following release

@AngledLuffa
Copy link
Collaborator

Frankly I'm not sure what you mean by trove, though

@michael-k
Copy link
Author

For some reason the classifiers are called “trove classifiers”. https://pypi.org/classifiers/ uses that and refers to https://peps.python.org/pep-0301/#distutils-trove-classification and the PEP links to http://www.catb.org/~esr/trove/

@AngledLuffa
Copy link
Collaborator

1.6.1 is out with 3.11 marked as viable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants