Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Added missing parameter in download_resources_json #1318

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

ider-zh
Copy link
Contributor

@ider-zh ider-zh commented Dec 4, 2023

Description

The code was updated to include a missing parameter in the function call download_resources_json(). The modification involved adding a new parameter resources_filepath=None to the function signature. This change allows for specifying a custom file path for the downloaded resources, while still providing a default value of None if no path is specified.

This modification ensures that the function call is now properly formatted and includes all required parameters. The bug has been fixed, and the code is now able to handle the download of resources correctly.

Fixes Issues

#1317

The code was updated to include a missing parameter in the function call download_resources_json(). The modification involved adding a new parameter resources_filepath=None to the function signature. This change allows for specifying a custom file path for the downloaded resources, while still providing a default value of None if no path is specified.

This modification ensures that the function call is now properly formatted and includes all required parameters. The bug has been fixed, and the code is now able to handle the download of resources correctly.
@AngledLuffa AngledLuffa merged commit c46df89 into stanfordnlp:dev Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants