Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxies parameters when downloading the model #638

Merged
merged 3 commits into from Mar 9, 2021

Conversation

TRHX
Copy link
Contributor

@TRHX TRHX commented Mar 8, 2021

Add proxy parameters when downloading the model to make it more convenient for Chinese users to use, the proxy parameter is optional. #638

>>> import stanza
>>> proxies = {'http': 'http://127.0.0.1:10809', 'https': 'http://127.0.0.1:10809'}
>>> stanza.download('en', proxies)

@AngledLuffa
Copy link
Collaborator

Would you make this the last argument of the parameters list instead of the first? Also, the .idea directory isn't supposed to be here, I believe.

@TRHX
Copy link
Contributor Author

TRHX commented Mar 9, 2021

Would you make this the last argument of the parameters list instead of the first? Also, the .idea directory isn't supposed to be here, I believe.

I have modified the location of the proxy parameter to the last one, and deleted the .idea directory.

@AngledLuffa AngledLuffa merged commit c3608dc into stanfordnlp:dev Mar 9, 2021
@AngledLuffa
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants