Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent.reset() not called between subsequent episodes in sim2real challenge #38

Closed
karkuspeter opened this issue May 2, 2020 · 1 comment

Comments

@karkuspeter
Copy link

Hi,

One would expect agent.reset() to be called in this loop:

for i in range(num_eval_episodes):
print('Episode: {}/{}'.format(i + 1, num_eval_episodes))
state = self.nav_env.reset()
while True:
action = agent.act(state)
state, reward, done, info = self.nav_env.step(action)
total_reward += reward
if done:
break
total_success += info['success']
total_spl += info['spl']

Is it missing by mistake?

@ChengshuLi
Copy link
Member

Thank you for pointing this out. We have added agent.reset() in this comment c96cef9.

This will be especially useful for recurrent policies because you would need to reset the hidden state in agent.reset().

Feel free to re-open this issue if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants