-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assume reporterOptions holds all options if configFile is !defined #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
@gjw Your changes look good to me. Would you mind update the README.md as well so people can reference it in the future use. Thanks! |
3 similar comments
stanleyhlng
modified the milestones:
mocha-multi-reporters@1.1.3,
mocha-multi-reporters@1.1.4
Mar 9, 2017
@gjw Thanks, it looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This straight up fixes #31 , at least for all my use cases.
We already get the options from mocha, whichever way people may be calling it programmatically. We don't work (well, it falls back to defaults) unless that options hash already contains a key pointing to a file to load its values from... so why not just use that as the entire reporter options config object, instead of having to require it from another file?