Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assume reporterOptions holds all options if configFile is !defined #32

Merged
merged 3 commits into from
Mar 9, 2017

Conversation

gjw
Copy link
Contributor

@gjw gjw commented Mar 8, 2017

This straight up fixes #31 , at least for all my use cases.

We already get the options from mocha, whichever way people may be calling it programmatically. We don't work (well, it falls back to defaults) unless that options hash already contains a key pointing to a file to load its values from... so why not just use that as the entire reporter options config object, instead of having to require it from another file?

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 8f8885c on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 8f8885c on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

@coveralls
Copy link

coveralls commented Mar 8, 2017

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 8f8885c on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

@stanleyhlng
Copy link
Owner

@gjw Your changes look good to me. Would you mind update the README.md as well so people can reference it in the future use. Thanks!

@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 2b6f802 on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 3d5f2f0 on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 3d5f2f0 on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 3d5f2f0 on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 89.024% when pulling 3d5f2f0 on gjw:B31-set-config-inline into 7d1ef64 on stanleyhlng:master.

@stanleyhlng
Copy link
Owner

@gjw Thanks, it looks great.

@stanleyhlng stanleyhlng merged commit 94a62a5 into stanleyhlng:master Mar 9, 2017
@stanleyhlng stanleyhlng self-requested a review March 9, 2017 04:18
@stanleyhlng
Copy link
Owner

@gjw gjw deleted the B31-set-config-inline branch March 9, 2017 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set configurations for reporters directly inside reporterOptions
3 participants