Added transparent GZIP decompression. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new constructors that allow the user to specify whether or not to detect GZIP compressed files and automatically decompress them during reading. Also do note that the size detection will not work correctly for files larger than 4GB. Signed-off-by: Martin Schroeder <martin.h.schroeder@intel.com>
|
The link to the associated Jenkins pull request is: |
| this(file, charset, completed, false); | ||
| } | ||
|
|
||
| public LargeText(final File file, Charset charset, boolean completed, boolean transparentUnGZIP) { |
There was a problem hiding this comment.
BTW the corresponding Unix command is gunzip, which might be a more familiar term (or not).
There was a problem hiding this comment.
Mhhm, somehow "transparentGunzip" also looks strange. How about: "transparentGzipInflate" or "transparentGZIPInflate"?
But I'm also okay with the first solution. Just reply with what you think is the best solution, and I will change it accordingly.
This includes corrected typos, indendation and variable names. The most important change is to removed the duplicated functionality of FileSession inside GzipAwareSession. Added copyright as per company policy. Signed-off-by: Martin Schroeder <martin.h.schroeder@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new constructors that allow the user
to specify whether or not to detect GZIP compressed files
and automatically decompress them during reading.
This is especially useful for Jenkins, as it will allow
transparent reading of GZIPed log files. A pull request
for the requisite change to Jenkins will follow shortly.
Do note that the API change is opt-in and backward-
compatible should thus not break any other package or
older Jenkins version.
Signed-off-by: Martin Schroeder martin.h.schroeder@intel.com