Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dependency on Guava (r06 -> 15.0) #27

Merged
merged 2 commits into from
Oct 29, 2013
Merged

Update the dependency on Guava (r06 -> 15.0) #27

merged 2 commits into from
Oct 29, 2013

Conversation

ebourg
Copy link
Contributor

@ebourg ebourg commented Sep 12, 2013

Hi,

Here is a patch upgrading the dependency on Guava. The latest release removed the MapMaker.makeComputingMap() method used by Stapler. The patch follows the migration guide published by the Guava team:

http://code.google.com/p/guava-libraries/wiki/MapMakerMigration
http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/cache/CacheBuilder.html

Thank you

kohsuke added a commit that referenced this pull request Oct 29, 2013
This merges pull request #27 except I stick to 14.0 for now
Conflicts:
	core/pom.xml
@kohsuke kohsuke merged commit ca95db1 into jenkinsci:master Oct 29, 2013
@ebourg
Copy link
Contributor Author

ebourg commented Oct 29, 2013

Thank you for merging this change Kohsuke. Did you find an issue with Guava 15.0 that forced you to stick with 14.0?

@kohsuke
Copy link
Member

kohsuke commented Oct 29, 2013

No, it's just that I made a change independently to go up to 14.0, and I guess I was mostly a little worried about forcing a version that's too new. You've verified that people who want to use Stapler with Guava 15.0 can do so, and I guess 14.0 felt like a good middle ground for those who are still linking with earlier versions of Guava (directly or indirectly.) From what I can tell, 15.0 removes some of the APIs present in earlier versions, and it looked like a bigger compatibility risk for those people.

Do you feel strongly that Stapler should depend on Guava 15.0?

@ebourg
Copy link
Contributor Author

ebourg commented Oct 30, 2013

I have no strong opinion on the upgrade to 15.0. I just noticed the incompatibility when upgrading the Debian package for Guava. It broke stapler as well as sisu-guice, jython and closure-compiler. So I reported the issue to the projects to ensure they all work with the same version of Guava. As long as Stapler also works with 15.0 I'm fine.

jglick added a commit that referenced this pull request Oct 31, 2013
…towards getting rid of the dependency altogether.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants