Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Averaged magnet current to set magnetic field strength #170

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Averaged magnet current to set magnetic field strength #170

merged 3 commits into from
Oct 28, 2021

Conversation

fisyak
Copy link
Member

@fisyak fisyak commented Oct 12, 2021

@kehw kehw requested a review from starsdong October 18, 2021 16:11
@starsdong
Copy link
Member

Dmitry and other colleagues,

Could you please take a review at this PR and comment/approve it? This PR is planned to be included in the upcoming lib release (SL21d) that is needed for upcoming FXT production? Thanks

dmarkh
dmarkh approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@dmarkh dmarkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains TPC-specific code and an IDL file (no corresponding db table requested). IDL file correctness was verified by CI, and I'm no expert in TPC codes. But, since I was specifically asked to do a review - here we go:
I formally approve this PR (given the notes above).

@starsdong
Copy link
Member

Thank you, Dmitry.

Irakli, among the reviewers, you are likely the most knowledgeable person for the TPC. Could you please help take a review and comment/approve this PR?

Thanks

@iraklic
Copy link
Member

iraklic commented Oct 26, 2021

Thank you, Dmitry.

Irakli, among the reviewers, you are likely the most knowledgeable person for the TPC. Could you please help take a review and comment/approve this PR?

Thanks

Hi @starsdong , I remember looking over Yuri's blog about corrections and I thought I already took action on this. I guess it slipped me. I just approved it.

Irakli

@starsdong
Copy link
Member

Shall we merge this in or it will be done automatically?

@plexoos
Copy link
Member

plexoos commented Oct 28, 2021

It's never been done automatically.

@starsdong starsdong merged commit b3e8010 into star-bnl:main Oct 28, 2021
jml985 pushed a commit that referenced this pull request Dec 7, 2021
@fisyak @jml985
Averaged magnet current to set magnetic field strength (#170)
6faed27 
* Add Gating Grid time shape

* Add new options

* Switch to averaged STAR main magnet current, add a few new chairs
marrbnl pushed a commit that referenced this pull request Dec 8, 2021
@fisyak @marrbnl
Averaged magnet current to set magnetic field strength (#170)
6e66101 
* Add Gating Grid time shape

* Add new options

* Switch to averaged STAR main magnet current, add a few new chairs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iraklic iraklic iraklic approved these changes

@dmarkh dmarkh dmarkh approved these changes

@akioogawa akioogawa Awaiting requested review from akioogawa akioogawa is a code owner

@fgeurts fgeurts Awaiting requested review from fgeurts fgeurts is a code owner

@plexoos plexoos Awaiting requested review from plexoos

@starsdong starsdong Awaiting requested review from starsdong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fisyak @starsdong @iraklic @plexoos @dmarkh