Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cut limits in EPD macro #188

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Fix cut limits in EPD macro #188

merged 2 commits into from
Nov 17, 2021

Conversation

liuxiaoyuyuyu
Copy link
Contributor

No description provided.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No point in saving this buggy variant of a code that does a simple 1D binning

@plexoos plexoos changed the title Fixed bugs by MAL Fix cut limits in EPD macro Nov 17, 2021
@starsdong
Copy link
Member

Hi Dmitri, I don't think we need further review on this. If possible, please help merge this PR to the main branch. Thanks

@plexoos plexoos merged commit 97324ef into star-bnl:main Nov 17, 2021
@plexoos plexoos added the bug Something isn't working label Dec 1, 2021
jml985 pushed a commit that referenced this pull request Dec 7, 2021
* Fixed bugs by MAL

* Apply suggestions from code review

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
marrbnl pushed a commit that referenced this pull request Dec 8, 2021
* Fixed bugs by MAL

* Apply suggestions from code review

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants