Fcs mudst #200
Merged
Fcs mudst #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from upstream on Friday, June 11, 2021
Updated StarGeo.xml to be able to acces this in dev2021
…er, heatsinks (draft) )
… rotation of middle disk
This includes material changes
…in PEEK bases, removed unnecessary code
…plified cooling tube connectors)
…es, add helper methods to StMuFcsCollection
starsdong
approved these changes
Nov 17, 2021
|
Dmitri and Grigory, Daniel is the owner of MuDst code. If you can help take a review of the new additions for including FCS data into MuDst. It is kind of urgent so we can get the data into fast offline MuDst. Thanks |
|
I have enough on my plate so I'll pass. Just comment here when it is ready to merge. |
akioogawa
approved these changes
Nov 17, 2021
jml985
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Initial readme on how to sparse checkout StarVMC * add .gitignore for working directories StarGeometry and xgeometry * edit description comment * Rotated middle disk by 30 deg to mactch actual installation. * simplified base file for fst geometry Updated StarGeo.xml to be able to acces this in dev2021 * Simplified FST geometry v1.1 ( cooling tubes, ribs, cooling tube holder, heatsinks (draft) ) * Adjustments to commented out simplified heatsinks and included 30 deg rotation of middle disk * Fixed syntax issue with middle disk rotation * Updated material definition for combined stainless and novec * Added 3 more cooling tubes, compressed heatsinks into single volumes in PEEK bases, removed unnecessary code * Compressed heatsinks and added 3 additional cooling tube volumes (simplified cooling tube connectors) * accept gavins changes. removed some dummy not used lines * Ring removed. * remove README for pull request * Fixes for PR * Initial addition of Fcs to MuDst, with StEvent->MuDst and MuDst->StEvent support * Addition of StMuFcsInfo, store reconstruction flag and detector indices, add helper methods to StMuFcsCollection * Fix old comments for FCS classes Co-authored-by: Flemming Videbaek <videbaks@rcas6010.rcf.bnl.gov> Co-authored-by: Flemming Videbaek <videbaek@bnl.gov> Co-authored-by: gavin-wilks <gavin.wilks@gmail.com> Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
marrbnl
pushed a commit
that referenced
this pull request
Dec 8, 2021
* Initial readme on how to sparse checkout StarVMC * add .gitignore for working directories StarGeometry and xgeometry * edit description comment * Rotated middle disk by 30 deg to mactch actual installation. * simplified base file for fst geometry Updated StarGeo.xml to be able to acces this in dev2021 * Simplified FST geometry v1.1 ( cooling tubes, ribs, cooling tube holder, heatsinks (draft) ) * Adjustments to commented out simplified heatsinks and included 30 deg rotation of middle disk * Fixed syntax issue with middle disk rotation * Updated material definition for combined stainless and novec * Added 3 more cooling tubes, compressed heatsinks into single volumes in PEEK bases, removed unnecessary code * Compressed heatsinks and added 3 additional cooling tube volumes (simplified cooling tube connectors) * accept gavins changes. removed some dummy not used lines * Ring removed. * remove README for pull request * Fixes for PR * Initial addition of Fcs to MuDst, with StEvent->MuDst and MuDst->StEvent support * Addition of StMuFcsInfo, store reconstruction flag and detector indices, add helper methods to StMuFcsCollection * Fix old comments for FCS classes Co-authored-by: Flemming Videbaek <videbaks@rcas6010.rcf.bnl.gov> Co-authored-by: Flemming Videbaek <videbaek@bnl.gov> Co-authored-by: gavin-wilks <gavin.wilks@gmail.com> Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements StEvent->StMuDst for FCS
Provides MuDst classes for StFcsHit, StFcsCluster, StFcsPoint and stores event level info in StFcsInfo. (Same methodology as FMS).