Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/Conscript-standard: fix build of StarVMC/StarGeometry with ROOT6 that doesn't ship ttables #259

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 17, 2021

rootcint -f .sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint.cxx -c .sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo.h StarVMC/Geomet
ry/StarGeoLinkDef.h
In file included from input_line_9:3:
./.sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo.h:949:10: fatal error: 'TDataSet.h' file not found
#include "TDataSet.h"
         ^~~~~~~~~~~~
Error: rootcint: compilation failure (.sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint3c991d560d_dictUmbrella.h)
cons: *** [.sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint.cxx] Error 1
cons: errors constructing .sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint.h

…that doesn't ship ttables

rootcint -f .sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint.cxx -c .sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo.h StarVMC/Geomet
ry/StarGeoLinkDef.h
In file included from input_line_9:3:
./.sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo.h:949:10: fatal error: 'TDataSet.h' file not found
#include "TDataSet.h"
         ^~~~~~~~~~~~
Error: rootcint: compilation failure (.sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint3c991d560d_dictUmbrella.h)
cons: *** [.sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint.cxx] Error 1
cons: errors constructing .sl73_x8664_gcc485/obj/StarVMC/StarGeometry/StarGeo_Cint.h
@veprbl veprbl added the ROOT6 Issues and changes related to transition from ROOT5 to ROOT6 label Dec 17, 2021
@klendathu2k
Copy link
Contributor

Remind me what %_IFLAGS adds to the command? The path to the exported include files?

@veprbl
Copy link
Member Author

veprbl commented Dec 17, 2021

This is an arbitrary name that is set $env->{_IFLAGS}. Specifically, it is _IFLAGS because that was in a snippet I found inside the cons itself. There is at least one another existing piece of code that does the same thing, but the logic is quite spread:

star-sw/mgr/Conscript-standard

Lines 1241 to 1243 in eae2c00

my $ROOTCINT_CPP =
$INCLUDE . $main::PATH_SEPARATOR . $INCLUDE . "/tables";
$ROOTCINT_CPP .= $main::PATH_SEPARATOR . $env1->{ENV}->{ROOTSRC};

star-sw/mgr/Conscript-standard

Lines 1255 to 1257 in eae2c00

my $cscanner =
find scan::cpp( $env1->{_cwd}, $ROOTCINT_CPP );
my $ROOTCINT_CPPPATH = $cscanner->iflags($env3); #print "ROOTCINT_CPPPATH = $ROOTCINT_CPPPATH\n"; die;

star-sw/mgr/Conscript-standard

Lines 1309 to 1310 in eae2c00

Command $env3 [ ($idlCintC , $idlCintH) ], @Deps,
qq (rootcint -f %> -c $ROOTCINT_CPPPATH -D__ROOT__ %1 %2);

Copy link
Contributor

@klendathu2k klendathu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the output of the tests... it looks like this is just appending the path to the include files (and a few other search paths as well). Looks good to me.

@plexoos plexoos merged commit 8eeccae into star-bnl:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROOT6 Issues and changes related to transition from ROOT5 to ROOT6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants