Revert "Fix EMC data in picoDst data in DAQ production" #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6896926.
veprbl
requested review from
zlchang,
akioogawa,
jml985,
nigmatkulov,
marrbnl,
plexoos,
genevb and
klendathu2k
as code owners
|
Thank you, Dmitri. I agree with the approach to revert the PR#295 for further investigation. Thanks |
genevb
approved these changes
Feb 17, 2022
plexoos
approved these changes
Feb 17, 2022
|
Dmitri, let us merge this in and get the main sync with DEV. We should follow up further on the triggerSimuMaker later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #303
Reverts #295 to give people more time to fix this while other PRs can be still accepted.
See tests done in veprbl#15