Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FST hits in MuDst #341

Merged
merged 3 commits into from
May 16, 2022
Merged

Add FST hits in MuDst #341

merged 3 commits into from
May 16, 2022

Conversation

techuan-huang
Copy link
Contributor

The purpose of this PR is to set up FST hits in MuDst events.

There are 3 additional classes (6 files) for FST was added (StMuFstCollection, StMuFstHit, and StMuFstUtil).
7 files are modified for adding the FST hits (StMuArrays, StMuDst, StMuDstMaker, and StMuTypes).

@starsdong
Copy link
Member

Hi experts, could you please take a look at this PR? Comment or approve this PR? To me I see the changes look straightforward and reasonable.

Copy link
Contributor

@sunxuhit sunxuhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@starsdong
Copy link
Member

Daniel, could you please take a look at this request, comment or approve this so we can include this into the library? Thanks

Copy link
Contributor

@jdbrice jdbrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version of StMuDst
ClassDef(StMuDst,5) --> ClassDef(StMuDst,6)

@techuan-huang
Copy link
Contributor Author

Hi Daniel,
Thanks for the comment. I guess I also need to do this for StMuDstMaker?
ClassDef(StMuDstMaker, 8) --> ClassDef(StMuDstMaker, 9)?

Copy link
Contributor

@jdbrice jdbrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

@jdbrice jdbrice merged commit 1534b05 into star-bnl:main May 16, 2022
@plexoos plexoos added this to the SL22b milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants