Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding etof-alignment table #348

Merged
merged 1 commit into from
May 12, 2022
Merged

adding etof-alignment table #348

merged 1 commit into from
May 12, 2022

Conversation

YannickSoehngen
Copy link
Contributor

New ETof-Detector-Alingment table

@dmarkh
Copy link
Contributor

dmarkh commented May 9, 2022

Questions:

a) How's that different from the existing GeomAlign table? Please indicate in the table name or in the description.
https://online.star.bnl.gov/dbExplorer/#Geometry/etof/reconV0/etofGeomAlign

b) New db table requires database initialization in addition to the IDL file. Could you please follow the steps described here:
https://drupal.star.bnl.gov/STAR/comp/db/how-to-user/new-table/

@dmarkh
Copy link
Contributor

dmarkh commented May 12, 2022 •
edited
Loading

Okay, the corresponding database structure is now initialized:
https://online.star.bnl.gov/dbExplorer/#Geometry/etof/reconV0/etofAlign

dmarkh
dmarkh approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@dmarkh dmarkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starsdong
Copy link
Member

Looks good to me too. Merging.

@starsdong starsdong merged commit 1c29e04 into star-bnl:main May 12, 2022
@plexoos plexoos added this to the SL22b milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starsdong starsdong starsdong approved these changes

@dmarkh dmarkh dmarkh approved these changes

@akioogawa akioogawa Awaiting requested review from akioogawa akioogawa is a code owner

@fgeurts fgeurts Awaiting requested review from fgeurts fgeurts is a code owner

@iraklic iraklic Awaiting requested review from iraklic iraklic is a code owner

@plexoos plexoos Awaiting requested review from plexoos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SL22b
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YannickSoehngen @dmarkh @starsdong @plexoos