Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add section about containers #380

Merged
merged 1 commit into from
Aug 4, 2022
Merged

docs: Add section about containers #380

merged 1 commit into from
Aug 4, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Jul 27, 2022

No description provided.

@plexoos plexoos added the documentation Improvements or additions to documentation label Jul 28, 2022
veprbl
veprbl approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plexoos
Copy link
Member Author

plexoos commented Jul 29, 2022

LGTM

🙇 Did you try to run the commands? One thing I don't understand is why singularity shell does not properly source the original entrypoint.sh. Maybe it is not supposed to... singularity run ... bash -l looks like a workaround to me.

@veprbl
Copy link
Member

veprbl commented Jul 29, 2022

LGTM

🙇 Did you try to run the commands?

No. Mostly was looking at the spelling.

One thing I don't understand is why singularity shell does not properly source the original entrypoint.sh. Maybe it is not supposed to... singularity run ... bash -l looks like a workaround to me.

Yeah, I believe this is what I've been observing when I tried it. I suppose one could create the /.singularity.d/env/ [1] in Docker and it might be picked up by singularity.

[1] https://docs.sylabs.io/guides/3.7/user-guide/environment_and_metadata.html

@plexoos plexoos merged commit 55ede56 into star-bnl:main Aug 4, 2022
@plexoos plexoos deleted the pr/update_docs branch August 4, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov nigmatkulov is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plexoos @veprbl