ci: Enable ROOT6 tests #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexoos
added
the
ROOT6
plexoos
force-pushed
the
pr/root6_enable_tests
branch
6 times, most recently
from
997eab3
to
6af042c
Compare
genevb
reviewed
Dec 5, 2022
plexoos
force-pushed
the
pr/root6_enable_tests
branch
from
e52167e
to
ba614cb
Compare
plexoos
force-pushed
the
pr/root6_enable_tests
branch
from
ba614cb
to
205f44a
Compare
plexoos
force-pushed
the
pr/root6_enable_tests
branch
from
205f44a
to
e913c17
Compare
plexoos
added a commit
that referenced
this pull request
Feb 1, 2023
See discussion in #452 #452 (review)
plexoos
force-pushed
the
pr/root6_enable_tests
branch
from
e8fcfa2
to
c62e563
Compare
plexoos
force-pushed
the
pr/root6_enable_tests
branch
2 times, most recently
from
e96c8ef
to
fb05a76
Compare
plexoos
force-pushed
the
pr/root6_enable_tests
branch
from
fb05a76
to
9424037
Compare
plexoos
requested review from
kkauder,
rkunnawa,
Navagyan and
fisyak
as code owners
plexoos
requested review from
R-Witt,
iraklic,
klendathu2k,
fgeurts,
dmarkh,
perevbnlgov and
veprbl
as code owners
|
This one is ready to go. Looks like all of the ROOT6 tests we have set up in CI pass. Only the usual checks are performed, i.e. the bfc.C macro can run on small real and simulated samples from various years without checking the quality of the output. Let me know if more inputs and options should be checked this way. |
iraklic
approved these changes
Sep 28, 2023
|
@iraklic Yes, rootcint is more strict in that sense. It needs to see the definitions of all used types while processing the macros |
veprbl
approved these changes
Sep 28, 2023
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.