Run XIX-XXII new dE/dx model and calibration #464
Conversation
fisyak
requested review from
akioogawa,
klendathu2k,
iraklic,
genevb,
dmarkh and
fgeurts
as code owners
|
Hmm.. I have concerns regarding the FilePath.idl We do not store the locations of external files in the database, usually. Yuri, is there an example of how you are going to use this structure? Is it for CINT files only? |
| @@ -16,4 +16,7 @@ | |||
| long np; /* no. of primary interactions per hit */ | |||
There was a problem hiding this comment.
I don't see any technical issues with this change to the g2t_tpc_hit structure. But there is an architectural one.
The g2t tables define (or at least express) the MC event data model. The data members being added are not
scored by geant simulation, but by a later stage of event processing / digitization. This is a mixing of concerns.
I would prefer that a separate data structure within TpcRS handle this additional information (along with the np, ne and adc fields). This can be addressed in a future PR.
There was a problem hiding this comment.
FilePath structure I do need to use exactly the same gain files as Tonko uses during data taking. It is supposed to be used as Cint files only. Really it is provide a time stamp to Tonko's gain files.
Yes, I agree that I miss modifications in StMcEvent. The modified structure is used in StTpcMcAnalysisMaker to tune up StTpcRSMaker.
I will add to this PR modification to StMcEvent
|
Hi Dmitry A., could you please take a look at the new commit? |
|
Hi, Xin
Not resolved. We just found that stepping back can avoid the crashes, but that doesn't mean that's the appropriate solution.
…-Gene
On Dec 17, 2022, at 4:24 PM, Xin Dong ***@***.***> wrote:
The StrangeMuDst issue was supposed to resolved now in the DEV?
|
|
Dmitry A., I would like to hear your further comments regarding Yuri's response to your question about FilePath.idl file. Do we have other better alternative that can work or we can proceed with this approach at this moment? THanks |
|
There is some urgency in getting this in the libraries on /afs as discussed at the meeting today. Unless anyone wants to raise a concern, we should merge this for the nightly build to pick up. The last call so to speak 🐱 |
|
On Dec 21, 2022, at 11:12 PM, Dmitri Smirnov ***@***.***> wrote:
Merged #464 into main.
11:12pm is too late to be picked up by the nightly 32-bit AutoBuild, and I wasn't watching for something to be merged later than that. It's just chance that I happened to check on things this late tonight.
Anyhow, AutoBuild did successfully compile the merged PR #443 , and then I ran the build system again myself to include this PR #464 and that compiled successfully., But I had to delay the start of the nightly test jobs to ensure they picked up the re-compiled DEV, and we'll have to wait until morning to find out how that goes.
…-Gene
|
|
Looks like pretty much all the nightly tests failed:
-Gene
dlopen error: /afs/rhic.bnl.gov/star/packages/DEV/.sl73_gcc485/LIB/libStDetectorDbMaker.so: undefined symbol: _ZN16St_TpcdEdxModelC10fgInstanceE
Load Error: Failed to load Dynamic link library /afs/rhic.bnl.gov/star/packages/DEV/.sl73_gcc485/LIB/libStDetectorDbMaker.so
QAInfo: doPs for libStMagF: Load total =337.242188 heap = 10.857117 and 0.037605( +0.003632)
BFC:FATAL - problem with loading of libStDetectorDbMaker
BFC:FATAL - detDb is switched off !!!!
root4star: .sl73_gcc485/OBJ/StRoot/StBFChain/StBFChain.cxx:177: virtual Int_t StBFChain::Load(): Assertion `libraryload!=kStErr' failed.
|
|
dev is broken because file |
|
I see...8 files were removed in total. I am removing and rebuilding DEV now. Amol's procedure for updating DEV doesn't account for deleted files....that has been a "to-do" item since we moved to git, but Amol departed before dealing with it. I'll see if I can figure out a good way to handle it automatically so this doesn't trip us up again. |
|
DEV is rebuilt if you want to test it, Yuri. We will find out tomorrow how the nightly tests perform. |
New dE/dx model and dE/dx calibration for Runs XIX - XXII