New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additon of StFwdTrack to StEvent, updates to StFwdTrackMaker to accomodate #492
Conversation
This PR incorporates the discussion that we had over several S&C meetings about the StFwdTracks. Specifically it:
|
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
Dear All, Daniel made quite great efforts in addressing the comments and suggestions. Would it be possible for reviewers to take a look and see whether we can proceed with this PR? Thanks |
@starsdong @plexoos |
I went through the updates from Daniel and I think all the comments are addressed and we are ready to merge. We wait until COB of Monday, in case anyone wants to bring up anything. If no further comment, Dmitri, let us merge this PR. Thanks |
I just fixed a conflict affecting a test using the FwdTrack option. Hopefully, it passes and we can merge 🤞 |
The code does not compile due to the following error:
A quick look reveals that this class https://github.com/star-bnl/star-sw/blob/main/StRoot/StEpdUtil/StEpdGeom.h includes the ClassDef macro and thus defines virtual methods. However, it does not define a virtual destructor which is required in this case. One way to fix this is to make StEpdGeom inherit from TObect |
This type is neither an StMaker nor an IO class so, using ClassDef is not critical. On the contrary, it causes an error due to missing virtual destructor when included in compiled code. E.g. see #492
This type is neither an StMaker nor an IO class so, using ClassDef is not critical. On the contrary, it causes an error due to missing virtual destructor when included in compiled code. E.g. see star-bnl#492
This type is neither an StMaker nor an IO class so, using ClassDef is not critical. On the contrary, it causes an error due to missing virtual destructor when included in compiled code. E.g. see #492
This PR replaces #397 (it was easier to start fresh)
Major updates