Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some functions in StRHICfFunction #533

Merged
merged 2 commits into from
May 19, 2023

Conversation

ggfdsa10
Copy link
Member

all of the checking function is removed
these functions are NOT necessary to RHICf reconstruction.
In more detail, see the comment below, (in PR #519 )


All of the input data-checking functions for RHICf come from the StRHICfFunction class. However, when someone uses a merged RHICf tool, those functions or codes will always be frozen.

Furthermore, all input data checkers simply ensure that the total number of input data is correct. For example, they check that the setPlateEnergy() function has been called as many times as there are plate energy arrays.

For this reason, I don’t think these checkers need to be included in all of the RHICf tools, so I plan to remove them from all RHICf tools soon. Commitd92b32d was made for the same reason.


all of the checking function is removed
@plexoos plexoos merged commit 46f3a78 into star-bnl:main May 19, 2023
156 checks passed
@ggfdsa10 ggfdsa10 deleted the StRHICfFunction branch May 20, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants