Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load libiconv module into envs #543

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: load libiconv module into envs #543

merged 1 commit into from
May 19, 2023

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented May 18, 2023

While linking StDbLib the linker cannot find libiconv, an indirect dependency via libxml2, unless it searches paths in LD_LIBRARY_PATH

@plexoos
fix: load libiconv module into envs
e4b66ed 
While linking StDbLib the linker cannot find libiconv, an indirect
dependency via libxml2, unless it searches paths in LD_LIBRARY_PATH
@plexoos plexoos added the infrastructure Build environment and configuration label May 18, 2023
@plexoos plexoos added this to the SL23c milestone May 18, 2023
genevb
genevb approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this allows StDb.so to be loaded in root4star batch mode (root4star -b), but it seems odd this wasn't needed for non-batch mode.

@plexoos plexoos merged commit 5c714aa into main May 19, 2023
@plexoos plexoos deleted the fix/load_libiconv branch May 19, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genevb genevb genevb approved these changes

@klendathu2k klendathu2k Awaiting requested review from klendathu2k klendathu2k is a code owner

@fisyak fisyak Awaiting requested review from fisyak fisyak is a code owner

Assignees
No one assigned
Labels
infrastructure Build environment and configuration
Projects
None yet
Milestone
SL23d
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plexoos @genevb