Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHICf Run and Event number address in StRHICfDbMaker #546

Merged
merged 3 commits into from
May 27, 2023

Conversation

ggfdsa10
Copy link
Member

PR 2. StRHICfDbMaker for RHICf Run and Event Number for the new STAR release

  1. StRHICfCollection
    2) this PR
  2. StMuDstMaker/StRHICfRawHit and StRHICfUtil
  3. StRHICfRawHitMaker

the new STAR release
1) StRHICfCollection
2) this PR
3) StMuDstMaker/StRHICfRawHit and StRHICfUtil
4) StRHICfRawHitMaker
@ggfdsa10 ggfdsa10 requested review from plexoos and genevb May 22, 2023 19:31
Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand what it means to get the numbers, but what does it mean to get the numbers' addresses? Are these meant to return pointers?

@ggfdsa10
Copy link
Member Author

These addresses simply return the index of the RHICf run and event number, in the order in which they are stored in the daq file (e.g. adc, tdc, etc.).

@genevb
Copy link
Contributor

genevb commented May 26, 2023

Thanks for the response, Seunghwan, but it remains unclear to me how the event number address is different from STAR's event ID, which is the count of STAR DAQ recorded events. Perhaps it is specific to the event count within a file, but that would then simply be a number you can get from the event's index within the MuDst or PicoDst.

Or when you say DAQ, do you mean the RHICf DAQ and not the STAR DAQ?

@ggfdsa10
Copy link
Member Author

ggfdsa10 commented May 27, 2023

As I understand it, when we run RHICf in STAR at 2017 year, we get the RHICf data (not STAR Data, it is just made by an external trigger system) at the same time as we get the DAQ data in STAR format also saved in STAR which name is st_xxx_rhicf_stream, so what I said DAQ mean STAR DAQ.

As you know, we have already analyzed using external RHICf data, which has its own sequential events and run numbers, and these values are currently stored in indexes 0 and 1 of the RHICf detector raw data inside the data acquired for STAR format.

It was necessary to cross-check to avoid any possible mistakes in the future (e.g. in existing standalone code or analysis), which is why we needed the run and event numbers used in the RHICf standalone analysis outside of STAR.

So those run and event numbers were defined by external RHICf triggers or instruments, not by hardware or triggers on the STAR.

I hope that answers your question.
and I'm so sorry for the confusion.

Thank you

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now understand what is meant by "address", and that these are simply functions that give that address. I think it would have been just as easy (or easier) to define a constant to hold the values 0 and 1 instead of functions, but it's not a big deal to me which way it gets implemented. Let's move on.

@ggfdsa10
Copy link
Member Author

Thank you very much for your approval,
and I want to request PRs for these revised things of the RHICf
As you know, there are two PRs left.
Can I push the merge?
If you are OK, I will keep going as soon as possible before MuDst production

@genevb genevb merged commit 090af9b into star-bnl:main May 27, 2023
156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants