Add RC files for ROOT

[plexoos]

It turns out the rootlogon.C and rootlogoff.C scripts were never saved in the repository, although they are used by every root4star job executed on the farm nodes. In fact, the jobs cannot properly run out of the box without the commands executed in these scripts. For reproducibility and analysis preservation reasons the RC scripts must be provided along with the code.

I took the currently used scripts from the default ROOT5 prefix in /afs and clean them up to keep only the minimally necessary commands. This revision works for me, but of course comments and suggestions are welcome.

It is expected that modifications for ROOT6 will be necessary and tracking such changes is essential.

[genevb]

I expect you should discuss this proposal with Jerome.

[plexoos]

We need these files to run test jobs in our CI. See #106

(Sent a note to Jerome as suggested by Gene but received no feedback so far)

[jlauret]

If I read this correctly, the proposed commits are simplified root logon / logoff and not the STAR standard scripts. If so, this should be fine.

[genevb]

It turns out the rootlogon.C and rootlogoff.C scripts were never saved in the repository

I'm a bit confused by this note. Is the above statement referring to the git repository? These scripts were in the CVS repository under root5/etc. Just trying to clarify what is being said here.

[genevb]

I'm also very confused by this email notification I received from github this morning. It's clearly listed as originating from user "Crhulhu", who is someone that I do not know ("Stanislav O. Pogrebnyak"). But if I look on the github web gui, the note came from user jlauret, whom I do know. Did github get confused? Some internet searching indicates that unknown user to be a software engineer who may be involved in cybersecurity - perhaps they hacked something on github?

…

-Gene On Aug 18, 2021, at 8:24 AM, Cthulhu ***@***.******@***.***>> wrote: If I read this correctly, the proposed commits are simplified root logon / logoff and not the STAR standard scripts. If so, this should be fine. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub<#71 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUK2OBILDVRMSKAUPCII4VTT5ORAPANCNFSM5BANNWFA>. Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!UCVj3WNnuZ2TaGcmFb52rQDJ5YQMpwGa7O6SZ8OiPlBYXfd_PAmpcjEKF-y7$> or Android<https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!P4SdNyxKAPE!UCVj3WNnuZ2TaGcmFb52rQDJ5YQMpwGa7O6SZ8OiPlBYXfd_PAmpcr8y_Go1$>.

[plexoos]

Yes, missing from this (Git) repository because the root5 directory was not migrated

[plexoos]

I'm also very confused by this email notification I received from github

I believe GitHub uses the full name of the user as recorded in the profile settings for email notifications. I suspect that the full "real" name for user @jlauret was set to "Cthulhu" as of this morning, however, it is now set to "JL". I don't think GitHub user cthulhu was involved in that email exchange/notification in any way.

[jlauret]

Are you sure you know user jlauret :-) ?? I reset to JL as Dmitri noted but kept the nice picture of myself and ... you are never sure what the real Cthulhu would be involved in :-D

As per my comment, I looked at what is proposed to be added. It is not the full rootlogon.C as appearing on disk at the SDCC. It is a stripped down version (minimal version) that seemed to be designed to support CI purpose (my interpretation). In that sense, we are good as no secrets are in - we just need to make sure one does not pull this and replace the real rootlogon from STAR.

[genevb]

I'm also very confused by this email notification I received from github

I believe GitHub uses the full name of the user as recorded in the profile settings for email notifications. I suspect that the full "real" name for user @jlauret was set to "Cthulhu" as of this morning, however, it is now set to "JL". I don't think GitHub user cthulhu was involved in that email exchange/notification in any way.

Thanks for the likely explanation, Dmitri. Authentication on github is apparently a guessing game. With RACF/SDCC systems, I have much higher trust/confidence in establishing who is whom with all the vetting that takes place before someone gets access to the systems.

[genevb]

Given @jlauret 's approval of these versions, I'll mark myself as approved.