Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampling the last entry of each page #28

Closed
clkao opened this issue Jun 26, 2016 · 5 comments
Closed

sampling the last entry of each page #28

clkao opened this issue Jun 26, 2016 · 5 comments

Comments

@clkao
Copy link

clkao commented Jun 26, 2016

It seems we are currently using the first entry of each page as sample. If a repo has been quiet lately, the chart will miss data points to the most recent date and look awkward.

@timqian
Copy link
Member

timqian commented Jun 26, 2016

I am not quiet sure about what you means, Do you have an example?

@clkao
Copy link
Author

clkao commented Jun 26, 2016

If you put in datproject/dat.land, you'll see the latest entry is Oct 2015, because that's the first entry of the last stargazer page. maybe just add an additional data point for the last entry of the last page?

timqian pushed a commit that referenced this issue Jun 26, 2016
@timqian
Copy link
Member

timqian commented Jun 26, 2016

This is a reasonable advice, thanks~
Check the new version.

@timqian
Copy link
Member

timqian commented Jun 26, 2016

The solution for now is not good enough. I am planning to add a data point for the searching date. See #29
In this way, We can also partially solve another problem: "One can only get the first 40000 star info from github api"
I think I can finish this tomorrow

@timqian
Copy link
Member

timqian commented Jun 28, 2016

done 10444c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants