Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix integeration test bugs #1025

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Conversation

anda-ren
Copy link
Member

Description

  • fix instance token bug
  • fix dataset uri env bug
  • fix dataset key prefix bug

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added bug 🐛 Something isn't working controller 🏘️ labels Aug 27, 2022
@anda-ren anda-ren added this to the v0.3 milestone Aug 27, 2022
@anda-ren anda-ren self-assigned this Aug 27, 2022
@anda-ren anda-ren added this to In progress in Starwhale Product via automation Aug 27, 2022
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starwhale Product automation moved this from In progress to Reviewer approved Aug 28, 2022
@jialeicui jialeicui merged commit c9cbd98 into star-whale:main Aug 28, 2022
Starwhale Product automation moved this from Reviewer approved to Done Aug 28, 2022
@anda-ren anda-ren deleted the it4 branch September 2, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants