Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(dataset): fix ppl loader data encode typo #1039

Merged
merged 1 commit into from
Aug 28, 2022
Merged

bug(dataset): fix ppl loader data encode typo #1039

merged 1 commit into from
Aug 28, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working dataset🐫 labels Aug 28, 2022
@tianweidut tianweidut added this to the v0.3 milestone Aug 28, 2022
@tianweidut tianweidut self-assigned this Aug 28, 2022
@tianweidut tianweidut added this to In progress in Starwhale Product via automation Aug 28, 2022
@tianweidut tianweidut changed the title bug(dataset): fix ppl loader data encode typo WIP bug(dataset): fix ppl loader data encode typo Aug 28, 2022
Starwhale Product automation moved this from In progress to Reviewer approved Aug 28, 2022
anda-ren
anda-ren approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit aaa00b3 into star-whale:main Aug 28, 2022
Starwhale Product automation moved this from Reviewer approved to Done Aug 28, 2022
@tianweidut tianweidut changed the title WIP bug(dataset): fix ppl loader data encode typo bug(dataset): fix ppl loader data encode typo Aug 28, 2022
@tianweidut tianweidut deleted the fix/data-loader branch April 17, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anda-ren anda-ren anda-ren approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

Assignees

@tianweidut tianweidut

Labels
bug 🐛 Something isn't working dataset🐫
Projects
Starwhale Product
  
Done
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tianweidut @anda-ren