Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(controller): unit test for project classes and some tiny change #1137

Merged
merged 2 commits into from
Sep 7, 2022
Merged

test(controller): unit test for project classes and some tiny change #1137

merged 2 commits into from
Sep 7, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 7, 2022 •
edited

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 7, 2022
@dreamlandliu dreamlandliu self-assigned this Sep 7, 2022
@dreamlandliu dreamlandliu added this to In progress in Starwhale Product via automation Sep 7, 2022
goldenxinxing
goldenxinxing approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starwhale Product automation moved this from In progress to Reviewer approved Sep 7, 2022
@goldenxinxing goldenxinxing merged commit e0305ae into star-whale:main Sep 7, 2022
Starwhale Product automation moved this from Reviewer approved to Done Sep 7, 2022
@dreamlandliu dreamlandliu deleted the ut/test_project branch January 6, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees

@dreamlandliu dreamlandliu

Labels
chore 🛎️ some tiny change controller 🏘️
Projects
Starwhale Product
  
Done
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dreamlandliu @goldenxinxing